[Poppler-bugs] [Bug 38586] support text rotation

Sun Jul 24 15:35:27 PDT 2011

https://bugs.freedesktop.org/show_bug.cgi?id=38586

--- Comment #17 from Albert Astals Cid <tsdgeos at terra.es> 2011-07-24 15:35:27 PDT ---
Some comments now that i have more time.

Please do not declare "namespace poppler" in popplerUtils.h since that is a
namespace we reserve for the poppler cpp frontend.
Please do not use "using namespace ;" constructs since we do not use them
anywhere in the utils code.

Please do not redefine the DEBUG macro or explain why you need to do it

I'd prefer you could remove the use of  
static GooString *gstr_buff0 = NULL; // a workspace in which I format strings
since makes me a bit worried

Also in 
-#define DOCTYPE "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01
Transitional//EN\">"
-#define DOCTYPE_FRAMES "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01
Frameset//EN\"\n\"http://www.w3.org/TR/html4/frameset.dtd\">"
+//#define DOCTYPE "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01
Transitional//EN\">"
+//#define DOCTYPE_FRAMES "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01
Frameset//EN\"\n\"http://www.w3.org/TR/html4/frameset.dtd\">"
+#define DOCTYPE "<!DOCTYPE html>"
+#define DOCTYPE_FRAMES "<!DOCTYPE html>"
If we are not going to need the old definitions, please just delete them
instead of commenting them

Also I'll need some pdf file showing the improvement (like the ones you used
for your screen captures)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.