[Poppler-bugs] [Bug 45549] poppler-glib API documentation improvements

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Feb 4 02:52:28 PST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=45549

--- Comment #9 from Carlos Garcia Campos <carlosgc at gnome.org> 2012-02-04 02:52:28 PST ---
Comment on attachment 56527
  --> https://bugs.freedesktop.org/attachment.cgi?id=56527
0005-NOT-SURE-ABOUT-THIS-gtk-doc-Fix-API-documentation-fo.patch

Review of attachment 56527:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=45549&attachment=56527)
-----------------------------------------------------------------

::: glib/poppler-document.cc
@@ +2359,4 @@
>   * @iter: a #PopplerLayersIter
>   * 
>   * Returns the #PopplerLayer associated with @iter.  It must be freed with
> + * g_object_unref().

Yes, this is correct. Return value has the transfer full annotation and it says
it returns a new #PopplerLayer, which is a GObject, so I think it's obvious you
have to use g_object_unref(), so I've simply removed the whole sentence.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Poppler-bugs mailing list