[Poppler-bugs] [Bug 49523] Splash::arbitraryTransformImage causes bogus memory allocation size

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49523

thomasf <Thomas.Freitag at alfa.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61476|0                           |1
        is obsolete|                            |

--- Comment #7 from thomasf <Thomas.Freitag at alfa.de> 2012-05-17 00:16:54 PDT ---
Created attachment 61739
  --> https://bugs.freedesktop.org/attachment.cgi?id=61739
Avoid bogus memory allocation size

The attached patch now runs successfully through my regression test. But be
aware, in round about 90 samples it changes the output. The reason for it is
that I replaced the algorithm for calculating scaledWidth and scaledHeight
(before rotating) with a better one and use the old one only if the calculated
values are unusable or we run into the special case of tiling patterns.
I could do that also the other way round, use the old algorithm taking the new
one only if we run into memory problems. But this would cause
a) that we use sometimes much more pixel than needed and so slow down rendering
and
b) that in case of striped images where the stripes varies around the memory
limit we will get a worse output because using different calculations.

I looked in every changed output, and where I thought that I got perhaps a
worse output I rendered it once again with 150 dpi instead of 72 dpi and
finally accept the changed output.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.