<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - library should be thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=50992#c49">Comment # 49</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - library should be thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a> from <a class="email" href="mailto:adamreichold@myopera.com" title="Adam Reichold <adamreichold@myopera.com>"> Adam Reichold</a> <pre>(In reply to <a href="show_bug.cgi?id=50992#c48">comment #48</a>) > The poppler patch fails to apply on master. Did you try "git apply --ignore-space-change"? (In reply to <a href="show_bug.cgi?id=50992#c47">comment #47</a>) > (In reply to <a href="show_bug.cgi?id=50992#c43">comment #43</a>) > > Created <a href="attachment.cgi?id=67636" name="attach_67636" title="more changes to get qt library thread safe">attachment 67636</a> <a href="attachment.cgi?id=67636&action=edit" title="more changes to get qt library thread safe">[details]</a> <a href='page.cgi?id=splinter.html&bug=50992&attachment=67636'>[review]</a> [review] [review] > > more changes to get qt library thread safe > > > > This patch also inlcudes the changes from Adam. I went through the code of > > okular and tried to make all calls of the poppler qt library thread safe. > > What are the incref and decref in Document supposed to do? I think they are supposed to the delete the document instance after the last thread that uses it has finished which might be after the thread that create it. Otherwise, the main, e.g. GUI, thread would have to wait for all work threads to finish before deletion.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>