<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - library should be thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=50992#c54">Comment # 54</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - library should be thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a> from <a class="email" href="mailto:tsdgeos@terra.es" title="Albert Astals Cid <tsdgeos@terra.es>"> Albert Astals Cid</a> <pre>Some quick comments before i have a change to try it in 2 hours or so. The Annot.cc change does not belong here, right? The recursion in Stream::addFilters does not belong here either i'd say, no? GBool fCopy seems a bad name for something that decides if the xref is going to be copied, can we call it copyXRef? Same for fMT Seems a bit weird leaving the non thread safe versions of getDocInfo and getDocInfoNF there, no? What's the use of them? In the qt4 frontend we don't need the incRef and decRef, that's poor's man solution. Users of qt4 frontend can put the Document * in a QSharedPointer to get the reference counting properly done (which by the way we should not need in Okular since the code ensure the PDF generator will only be deleted once all the threads have finished)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>