<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #67775 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992#c61">Comment # 61</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a>
from <span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=67852" name="attach_67852" title="final thread safe patch">attachment 67852</a> <a href="attachment.cgi?id=67852&action=edit" title="final thread safe patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=50992&attachment=67852'>[review]</a>
final thread safe patch
When I uploaded my patch on thursday I still wasn't completely satisfied with
the catalog implementation: Even if it works, I saw possible gaps. So I worked
on a more complete version today morning.
After that I made several valgrind tests and found three memory leaks, two in
my implementation of this patch, which I solved, and one, which doesn't depend
on this patch but where I already uploaded a patch to <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Memory leak in CharCodeToUnicode"
href="show_bug.cgi?id=54702">bug 54702</a>.
After that I run a regtest with pdftoppm (with my testcase, which uses threads)
and one with pdftocairo (without using threads) and didn't find any further
problems.
I also made again okular tests, following content, add annotations, save as PDF
with filled forms, everything worked fine. The only problem I had was when
opening a PDF with sound, it didn't play. But I think it is because I use
okular under ubuntu without having the correct player installed (or isn't it
possible at all?).
So I upload here my (first) final patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>