<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] make LinkRendition properties available in Qt4 frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=55378#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] make LinkRendition properties available in Qt4 frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=55378">bug 55378</a> from <a class="email" href="mailto:tsdgeos@terra.es" title="Albert Astals Cid <tsdgeos@terra.es>"> Albert Astals Cid</a> <pre>Could you try to avoid whitespace only changes? I know you are actually fixing stuff but it makes the patches a bit harder to review. The "delete linkAction;" removal seems like it does not belong to this patch? We don't have an enum for the operations thing in the poppler core? Maybe it's worth adding? Could you keep the old LinkRendition constructor and mark it as deprecated so we don't break the ABI unccessesarly?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>