<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #67852 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992#c67">Comment # 67</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a>
from <span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=68025" name="attach_68025" title="lock inc/decRef final patch two">attachment 68025</a> <a href="attachment.cgi?id=68025&action=edit" title="lock inc/decRef final patch two">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=50992&attachment=68025'>[review]</a>
lock inc/decRef final patch two
(In reply to <a href="show_bug.cgi?id=50992#c66">comment #66</a>)
<span class="quote">>
> Do we need some more locks or helgrind is just reporting wrong?</span >
helgrind is reporting right, we need some more locks (even if I cannot
reconstruct it: if I start okular with helgrind, I get tons of error messages
in the qt area, but I can't find a report like Yours).
I'm not completely sure if in this case it would be better to copy the array,
too. But I haven't found a testcase for it, and locks are needed in either
case, not only for arrays, but for dicts and streams, too, because it is
possible that they are shared over threads in some cases.
BTW, because I had to create a new patch anyway, I also changed the getDocInfo
stuff now.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>