<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:tobias.koenig@kdab.com" title="Tobias Koenig <tobias.koenig@kdab.com>"> <span class="fn">Tobias Koenig</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] make LinkRendition properties available in Qt4 frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=55378">bug 55378</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #67766 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] make LinkRendition properties available in Qt4 frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=55378#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] make LinkRendition properties available in Qt4 frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=55378">bug 55378</a>
from <span class="vcard"><a class="email" href="mailto:tobias.koenig@kdab.com" title="Tobias Koenig <tobias.koenig@kdab.com>"> <span class="fn">Tobias Koenig</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=68242" name="attach_68242" title="Updated patch">attachment 68242</a> <a href="attachment.cgi?id=68242&action=edit" title="Updated patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=55378&attachment=68242'>[review]</a>
Updated patch
I have updated the patch according to the review comments now. The 'delete
link' is still in place, because deleting the link object at this place is
wrong and just worked by coincidence. Using the new LinkRendition object with a
ScreenAnnotation uncovers that.
The constructor of LinkRendition still takes an integer for the operation
parameter, because I don't see a clean way to make the enum from the
::LinkRendition class available in the header file. Internally however the new
enum is used.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>