<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - handling of rtl text inversion is too naive" href="https://bugs.freedesktop.org/show_bug.cgi?id=55977#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - handling of rtl text inversion is too naive" href="https://bugs.freedesktop.org/show_bug.cgi?id=55977">bug 55977</a> from <a class="email" href="mailto:tsdgeos@terra.es" title="Albert Astals Cid <tsdgeos@terra.es>"> Albert Astals Cid</a> <pre>Hi, thanks for the contribution! Some weak points of the patch (have not really looked at the contents yet, just at the form): * You are missing support for the cmake build system * You are exposing the #if HAVE_ICU in TextOutputDev.h (for a variable i never see you assign or change) * If i have icu and fribidi it will say that both are used, when that's not true (please switch it to something like the cms check that says "with lcms" or "with lcms2" depending on the library used)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>