<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - library should be thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=50992#c69">Comment # 69</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - library should be thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a> from <a class="email" href="mailto:adamreichold@myopera.com" title="Adam Reichold <adamreichold@myopera.com>"> Adam Reichold</a> <pre>(In reply to <a href="show_bug.cgi?id=50992#c68">comment #68</a>) > Created <a href="attachment.cgi?id=68840" name="attach_68840" title="a new rebased patch">attachment 68840</a> <a href="attachment.cgi?id=68840&action=edit" title="a new rebased patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=50992&attachment=68840'>[review]</a> [review] > a new rebased patch > > I just encountered that the patch is no more appliable. So I created a > rebased patch. I also changed the preprocessor directive to > POPPLER_QT4_OVERPRINT_PREVIEW how Adam mentioned. Limited testing of parallel rendering using this latest patch does seem to work as expected. Concerning a more fundamental question: It is a big patch, so it takes very much to review and I understand that it does not get into master easily. But it seems a lot of work to continuous rebase it. From looking at the code, it seems unlikely to me that it will introduce regressions in the _single-threaded_ usage of Poppler, i.e. programs that do not take advantage of these changes should not be affected. (Aside from the slight performance decrease because of less sharing that is.) I really do not want to be presumptuous. I am not the maintainer, so I do not have to make the though calls. However, my personal opinion is that it would probably make sense to be bold and push this even if we find a few problems by long-time usage. (It could also receive more testing in the Poppler prereleases leading to 0.22 this way.)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>