<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [Patch] Building Poppler-0.18.gir should not give warnings" href="https://bugs.freedesktop.org/show_bug.cgi?id=56218#c10">Comment # 10</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [Patch] Building Poppler-0.18.gir should not give warnings" href="https://bugs.freedesktop.org/show_bug.cgi?id=56218">bug 56218</a> from <a class="email" href="mailto:hib@hiberis.nl" title="Hib Eris <hib@hiberis.nl>"> Hib Eris</a> <pre>(In reply to <a href="show_bug.cgi?id=56218#c5">comment #5</a>) > Comment on <a href="attachment.cgi?id=68831" name="attach_68831" title="0002-Include-Gio-2.0-for-introspection.patch">attachment 68831</a> <a href="attachment.cgi?id=68831&action=edit" title="0002-Include-Gio-2.0-for-introspection.patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=56218&attachment=68831'>[review]</a> [review] > 0002-Include-Gio-2.0-for-introspection.patch > > Review of <a href="attachment.cgi?id=68831" name="attach_68831" title="0002-Include-Gio-2.0-for-introspection.patch">attachment 68831</a> <a href="attachment.cgi?id=68831&action=edit" title="0002-Include-Gio-2.0-for-introspection.patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=56218&attachment=68831'>[review]</a> [review]: > ----------------------------------------------------------------- > > This look goods to me. Not only resolves the warnings, but also makes > poppler_document_new_from_stream" and poppler_document_new_from_gfile > introspectable. Right, now I am thinking, shouldn't we also change the version number in the gir file? I am not sure what the 0.18 in Poppler-0.18.gir is supposed to reflect.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>