<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] Image quality worse compared to Adobe Reader" href="https://bugs.freedesktop.org/show_bug.cgi?id=22138#c34">Comment # 34</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] Image quality worse compared to Adobe Reader" href="https://bugs.freedesktop.org/show_bug.cgi?id=22138">bug 22138</a> from <a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> Thomas Freitag</a> <pre>(In reply to <a href="show_bug.cgi?id=22138#c31">comment #31</a>) > Thanks for the patch Adrian, i'll try to have a look to squeeze it in before > the 0.22 beta 2 this thursday. > > Thomas, as Splash guru, can you give it a quick look too? I hadn't a look the algorithm itself and I didn't test the patch. You should see in Your regtest if it has the desired result. But what I can say is that it replaces the correct function: it is called only when there is an upscale in both dimensions (x and y), and hopefully here we get a better quality. So one hint for Your tests: You should render some PDF with images at least with 300 dpi. With 150 dpi this function in splash is seldom called, because most images inside Your PDF Suite have at least 150 dpi (as far as I remember). And just to be complete: for downscaling an image it isn't necessary, there the Bresenham algorithm is well enough, so the patch should do what is expected. So in my eyes the patch is okay!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>