<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - library should be thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=50992#c103">Comment # 103</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - library should be thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a> from <a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> Thomas Freitag</a> <pre>(In reply to <a href="show_bug.cgi?id=50992#c102">comment #102</a>) > Yes, having the same rendering is important, but to be honest i like to > understand why the code is there and why it does what it does. And You really understand every part of poppler code :-) ? Okay, kidding aside, I had a first deeper look into it: Annots are not thread safe because the Catalog is not thread safe because I removed that part from the patch when I create this page render only stuff. And I removed it because it wasn't there when I uploaded my first thread safe patch for page rendering only (which was regtested by me long time ago). Of course I could insert now the catalog part again and see what happens, but then we'll probably be back to my complete patch in a few hours. > > If you want to delay the release just propose it on the mailing list, i have > no problem, it's just random dates i throw up and stick because no one > complains. The problem in the code of poppler is the usage of doc and xref and doc->getXRef() everywhere. As I mentioned: xref is not thread safe and need therefore to be copied. I don't know a good way to make poppler thread safe in smaller steps without any compromises. If we want to do that we have probably to rewrite the complete code. Therefore a delay of a few days will probably not help. Do You have any other suggestions?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>