<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - handling of rtl text inversion is too naive" href="https://bugs.freedesktop.org/show_bug.cgi?id=55977#c15">Comment # 15</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - handling of rtl text inversion is too naive" href="https://bugs.freedesktop.org/show_bug.cgi?id=55977">bug 55977</a> from <a class="email" href="mailto:alexbodn.groups@gmail.com" title="alex <alexbodn.groups@gmail.com>"> alex</a> <pre>(In reply to <a href="show_bug.cgi?id=55977#c14">comment #14</a>) > You're still not convincing me as why we *need* an enum there. > > Why would a user of this functions pass different values of the enum? In > which situations? Are you expecting the code that uses the function to call > it with different values of the enum? Why? When? i'll sincerely tell you that this might not be the best place to put this option. maybe the reordering method should better be an attribute of the document, to be given or autodetected at document load, by analyzing info on the program that created it. this should need a table with various known programs etc. however this pair of patches fix (almostly) 2 main aspects of rtl support shortcomings, it'll whet my taste to later inquire poppler more deeply in order to give a more complete solution, that would include rtl text selection too. that would work higher in the document load process and (probably) move the reordering method to the poppler doc creation, as an optional parameter, as i said. best regards, alex</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>