<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] pdftops does not crop" href="https://bugs.freedesktop.org/show_bug.cgi?id=30692#c13">Comment # 13</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] pdftops does not crop" href="https://bugs.freedesktop.org/show_bug.cgi?id=30692">bug 30692</a> from <a class="email" href="mailto:tsdgeos@terra.es" title="Albert Astals Cid <tsdgeos@terra.es>"> Albert Astals Cid</a> <pre>(In reply to <a href="show_bug.cgi?id=30692#c12">comment #12</a>) > Created <a href="attachment.cgi?id=70289" name="attach_70289" title="patch against the 19 Nov 12 git source">attachment 70289</a> <a href="attachment.cgi?id=70289&action=edit" title="patch against the 19 Nov 12 git source">[details]</a> <a href='page.cgi?id=splinter.html&bug=30692&attachment=70289'>[review]</a> [review] > patch against the 19 Nov 12 git source > > I made a version of the patch against 19 Nov 12 source. The patch still > works for me with the PDF that I attached previously. > createGfx() calls makeBox() and then Gfx(). > makeBox() sometimes sets crop to FALSE, and then createGfx() does not pass a > crop box to Gfx(). > The patch uses the original value of crop in the call to Gfx(). > Some files, like the one that I attached, draw outside the crop box, so even > if the PDF sets a crop box of a given size, you still need to generate the > postscript commands to crop to that size. Right, this still does not make sense, you are creating a tempvalue so that the returned value for makeBox is not used, if that is what you really want, why just not remove that parameter? On the other hand if this is about the PS conversion i do think that it is the PSOutputDev that should be modified and for example cropping itself on the box passed in the state of startPage ?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>