<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] pdftops does not crop" href="https://bugs.freedesktop.org/show_bug.cgi?id=30692#c15">Comment # 15</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] pdftops does not crop" href="https://bugs.freedesktop.org/show_bug.cgi?id=30692">bug 30692</a> from <a class="email" href="mailto:tsdgeos@terra.es" title="Albert Astals Cid <tsdgeos@terra.es>"> Albert Astals Cid</a> <pre>(In reply to <a href="show_bug.cgi?id=30692#c14">comment #14</a>) > >if that is what you really want, why just not remove that parameter? > > There are several calls to makeBox(). One of the calls to makeBox() in > PSOutputDev::checkPageSlice() uses the crop parameter. Ah, right, didn't see them > > >i do think that it is the PSOutputDev that should be modified > > I think that Page::createGfx() is the right place because it calls makeBox() > (which returns both the box and the crop flag) and it makes the crop > decision when it sets arguments to new Gfx(). The further that you separate > the place that has the information from the place that makes the decision, > the messier it gets. > > Wouldn't doing it anywhere else require splitting Page::createGfx() into two > parts or making more internals of Page or Gfx public? Why? The issue as I see it is that you give the PSOutputDev a box, and it allows commands outside that box to be rendered, that is wrong and shall be fixed at the PSOutputDev level, not somewhere else.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>