<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] pdftops does not crop"
href="https://bugs.freedesktop.org/show_bug.cgi?id=30692#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] pdftops does not crop"
href="https://bugs.freedesktop.org/show_bug.cgi?id=30692">bug 30692</a>
from <span class="vcard"><a class="email" href="mailto:williambader@hotmail.com" title="William Bader <williambader@hotmail.com>"> <span class="fn">William Bader</span></a>
</span></b>
<pre><span class="quote">>if that is what you really want, why just not remove that parameter?</span >
There are several calls to makeBox(). One of the calls to makeBox() in
PSOutputDev::checkPageSlice() uses the crop parameter.
<span class="quote">>i do think that it is the PSOutputDev that should be modified</span >
I think that Page::createGfx() is the right place because it calls makeBox()
(which returns both the box and the crop flag) and it makes the crop decision
when it sets arguments to new Gfx(). The further that you separate the place
that has the information from the place that makes the decision, the messier it
gets.
Wouldn't doing it anywhere else require splitting Page::createGfx() into two
parts or making more internals of Page or Gfx public?
William</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>