<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Fix warning on deprecated Poppler::Annotation::window"
href="https://bugs.freedesktop.org/show_bug.cgi?id=57807#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Fix warning on deprecated Poppler::Annotation::window"
href="https://bugs.freedesktop.org/show_bug.cgi?id=57807">bug 57807</a>
from <span class="vcard"><a class="email" href="mailto:adamreichold@myopera.com" title="Adam Reichold <adamreichold@myopera.com>"> <span class="fn">Adam Reichold</span></a>
</span></b>
<pre>Hello Hib,
I am not sure whether it is good style to work the solution of this
implementation problem into a public header. At least for GCC 4.6 and later, it
should be possible to resolve this locally using e.g.
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
Annotation::Annotation( AnnotationPrivate &dd, const QDomNode &annNode )
: d_ptr( &dd )
{
[...]
}
#pragma GCC diagnostic pop
Not sure what is worse, putting it into the headers or using a solution that
only works for a single compiler. :-(</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>