<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:hib@hiberis.nl" title="Hib Eris <hib@hiberis.nl>"> <span class="fn">Hib Eris</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - Fix warning on deprecated Poppler::Annotation::window"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=57807">bug 57807</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #70930 is obsolete</td>
           <td>
                
           </td>
           <td>1
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - Fix warning on deprecated Poppler::Annotation::window"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=57807#c2">Comment # 2</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - Fix warning on deprecated Poppler::Annotation::window"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=57807">bug 57807</a>
              from <span class="vcard"><a class="email" href="mailto:hib@hiberis.nl" title="Hib Eris <hib@hiberis.nl>"> <span class="fn">Hib Eris</span></a>
</span></b>
        <pre>Created <span class=""><a href="attachment.cgi?id=71193" name="attach_71193" title="deprecated-warning.patch">attachment 71193</a> <a href="attachment.cgi?id=71193&action=edit" title="deprecated-warning.patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=57807&attachment=71193'>[review]</a>
deprecated-warning.patch

(In reply to <a href="show_bug.cgi?id=57807#c1">comment #1</a>)

<span class="quote">> I am not sure whether it is good style to work the solution of this
> implementation problem into a public header.</span >

You are right. I reworked my patch to a more generic solution defining
POPPLER_DECL_DEPRECATED to replace Q_DECL_DEPRECATED.

What do you think of it?</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>