<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] Feature : extract media in html format" href="https://bugs.freedesktop.org/show_bug.cgi?id=56843#c15">Comment # 15</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] Feature : extract media in html format" href="https://bugs.freedesktop.org/show_bug.cgi?id=56843">bug 56843</a> from <a class="email" href="mailto:tsdgeos@terra.es" title="Albert Astals Cid <tsdgeos@terra.es>"> Albert Astals Cid</a> <pre>+ Object obj1; + obj1.free(); You don't need to free the object just after creating it (it is not *wrong* per se but it's a bit weird) AnnotRichMedia::getConfigurations() returns a new GooList everytime but HtmlOutputDev::doProcessRichMedia does not delete the list (i'd say you don't need to delete the contents, but better check it). Also it'd be good if in the header file you mention that the caller of AnnotRichMedia::getConfigurations is the one responsible for deleting the GooList but not the contents of it (in case i'm right) //ok = gFalse; Seems like it'd be a good idea to set that? You have some commented out code in HtmlOutputDev::endPage, maybe remove it? Besides that is looking quite good :-)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>