<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] Add wrapper for Annot::setFlags"
href="https://bugs.freedesktop.org/show_bug.cgi?id=58015#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] Add wrapper for Annot::setFlags"
href="https://bugs.freedesktop.org/show_bug.cgi?id=58015">bug 58015</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=71197" name="attach_71197" title="patch: add poppler_annot_set_flags">attachment 71197</a> <a href="attachment.cgi?id=71197&action=edit" title="patch: add poppler_annot_set_flags">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=58015&attachment=71197'>[review]</a>
patch: add poppler_annot_set_flags
Review of <span class=""><a href="attachment.cgi?id=71197" name="attach_71197" title="patch: add poppler_annot_set_flags">attachment 71197</a> <a href="attachment.cgi?id=71197&action=edit" title="patch: add poppler_annot_set_flags">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=58015&attachment=71197'>[review]</a>:
-----------------------------------------------------------------
Patch looks good to me. Albert, the patch is simple and not risky, I think it
can go in 0.22.
::: glib/poppler-annot.cc
@@ +513,5 @@
<span class="quote">> + * @flags: a #PopplerAnnotFlag
> + *
> + * Sets the flag field specifying various characteristics of the
> + * @poppler_annot.
> + *</span >
Please add a Since: tag here 0.22 or 0.24
@@ +520,5 @@
<span class="quote">> +poppler_annot_set_flags (PopplerAnnot *poppler_annot, PopplerAnnotFlag flags)
> +{
> + g_return_if_fail (POPPLER_IS_ANNOT (poppler_annot));
> +
> + return poppler_annot->annot->setFlags ((guint) flags);</span >
Remove the return, since the method is void. Also, add an early return if flags
don't change, since Annot::setFlags doesn't check it and the xref will be
updated and the document marked as modified.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>