<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:corentin.allemand@aquafadas.com" title="Allemand Corentin <corentin.allemand@aquafadas.com>"> <span class="fn">Allemand Corentin</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] Feature : extract media in html format"
href="https://bugs.freedesktop.org/show_bug.cgi?id=56843">bug 56843</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #71088 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] Feature : extract media in html format"
href="https://bugs.freedesktop.org/show_bug.cgi?id=56843#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] Feature : extract media in html format"
href="https://bugs.freedesktop.org/show_bug.cgi?id=56843">bug 56843</a>
from <span class="vcard"><a class="email" href="mailto:corentin.allemand@aquafadas.com" title="Allemand Corentin <corentin.allemand@aquafadas.com>"> <span class="fn">Allemand Corentin</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=71228" name="attach_71228" title="Patch for extract media">attachment 71228</a> <a href="attachment.cgi?id=71228&action=edit" title="Patch for extract media">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=56843&attachment=71228'>[review]</a>
Patch for extract media
(In reply to <a href="show_bug.cgi?id=56843#c15">comment #15</a>)
<span class="quote">> + Object obj1;
> + obj1.free();
>
> You don't need to free the object just after creating it (it is not *wrong*
> per se but it's a bit weird)</span >
It's just an oversight after you have cleaned the code
<span class="quote">>
> AnnotRichMedia::getConfigurations() returns a new GooList everytime but
> HtmlOutputDev::doProcessRichMedia does not delete the list (i'd say you
> don't need to delete the contents, but better check it). Also it'd be good
> if in the header file you mention that the caller of
> AnnotRichMedia::getConfigurations is the one responsible for deleting the
> GooList but not the contents of it (in case i'm right)
>
> //ok = gFalse;
> Seems like it'd be a good idea to set that?</span >
It's just an oversight after you have cleaned the code
<span class="quote">>
> You have some commented out code in HtmlOutputDev::endPage, maybe remove it?</span >
It's just an oversight after you have cleaned the code
<span class="quote">> Besides that is looking quite good :-)</span >
Thank you for the time to incorporate changes</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>