<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - pdfinfo/pdffonts cannot process >2GB files"
href="https://bugs.freedesktop.org/show_bug.cgi?id=44085">bug 44085</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #72449 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - pdfinfo/pdffonts cannot process >2GB files"
href="https://bugs.freedesktop.org/show_bug.cgi?id=44085#c25">Comment # 25</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - pdfinfo/pdffonts cannot process >2GB files"
href="https://bugs.freedesktop.org/show_bug.cgi?id=44085">bug 44085</a>
from <span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=72539" name="attach_72539" title="fix uninitialized memory">attachment 72539</a> <a href="attachment.cgi?id=72539&action=edit" title="fix uninitialized memory">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=44085&attachment=72539'>[review]</a>
fix uninitialized memory
(In reply to <a href="show_bug.cgi?id=44085#c24">comment #24</a>)
<span class="quote">> Created <span class="bz_obsolete"><a href="attachment.cgi?id=72449" name="attach_72449" title="fix uninitialised memory">attachment 72449</a> <a href="attachment.cgi?id=72449&action=edit" title="fix uninitialised memory">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=44085&attachment=72449'>[review]</a> [review]
> fix uninitialised memory
>
> I've found the rendering differences for bug-poppler26533.pdf to be caused
> by uninitialised memory in splash. This patch fixes the problem.</span >
Thanks for figuring out why almost all tests failed if a page using tiling
patterns. But I think Your patch is slightly incomplete:
1. You remove the initialization of the bitmap if paintType = 2 is used. This
paintType is seldom used, one example is page 745 of spec PDF32000_2008.pdf.
2. I think the better way to initialize the memory is to use the paperColor
(which in pdftoppm is the same You're using: white) and use the existing
Splash::clear function.
This patch changes it and therefore should replace Your patch for it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>