<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992#c140">Comment # 140</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a>
from <span class="vcard"><a class="email" href="mailto:tsdgeos@terra.es" title="Albert Astals Cid <tsdgeos@terra.es>"> <span class="fn">Albert Astals Cid</span></a>
</span></b>
<pre>Test Regression is good, horray!
Now let's look at the code :-)
First the small easy stuff ;-)
In the qt4 frotend there's this change
- m_doc->doc->getDocInfo( &info );
- if ( !info.isDict() )
+ XRef *xref = m_doc->doc->getXRef()->copy();
+ Object *infoObj = xref->getDocInfo(&info);
+ if ( !infoObj->isDict() ) {
return QStringList();
+ }
- Dict *infoDict = info.getDict();
+ Dict *infoDict = infoObj->getDict();
Any reason we can not keep using info? i.e. something like
- m_doc->doc->getDocInfo( &info );
+ XRef *xref = m_doc->doc->getXRef()->copy();
+ xref->getDocInfo(&info);
if ( !info.isDict() )
return QStringList();
Dict *infoDict = info.getDict();
Rest of the code looks good, i'd introduce two improvements, but let's do it
*LATER*, one introducing something similar to the concept of the mutexlocker
that unlocks the mutex on destruction (making it much easier to deal if early
returns, etc) and second changing some of the lock booleans to enums so
page = doc->getCatalog()->findPage (ref.num, ref.gen, gFalse);
looks like
page = doc->getCatalog()->findPage (ref.num, ref.gen, Poppler::DoNotLock);
making the code a bit easier to read when you go around
I'm happy with the current state expect the minor question about the qt4
frontend.
Anyone else has any comment?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>