<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #72952 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992#c136">Comment # 136</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a>
from <span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=72996" name="attach_72996" title="Additional locks for bug-poppler10898.pdf">attachment 72996</a> <a href="attachment.cgi?id=72996&action=edit" title="Additional locks for bug-poppler10898.pdf">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=50992&attachment=72996'>[review]</a>
Additional locks for bug-poppler10898.pdf
(In reply to <a href="show_bug.cgi?id=50992#c135">comment #135</a>)
<span class="quote">> With attachment.cgi?id=72952 bug-poppler10898.pdf is crashing on me again
> with the while loop</span >
When I read Your comment today early morning I immediately started a new
while-loop test. After half a hour I started writing a new comment, but just
before I wanted to press the submit button, the test crashed. Unfortunately I
forgot to allow core dumps, so I couldn't figure out the reason.
The former reason for crashes is definitely solved: two threads were calling
Dict::copy on the same dict at the same time, but because Dict:copy also
modifies the dict entry object, this caused the crashes. I solved that by
inserting lock/unlock pairs in the method.
Because I have no core dump and You also didn't attach backtraces, I've to
guess now: In the crashes before there was always also an array involved, but
there are no lock/unlock pairs in the array implementation. I tried to proof
that idea, starting the while-loop test with the clang compiled version 2 hours
ago.
In the meantime I inserted the lock/unlock pairs in the array implementation,
run a complete regtest on this new version, but the clang version is still
running.
So I upload the new patch now and ask You to test it, too, and provide a
backtrace if it still crashes. I'll stop now the clang test and start a normal
test with core dumps enables, too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>