<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992#c141">Comment # 141</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - library should be thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=50992">bug 50992</a>
from <span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=50992#c140">comment #140</a>)
<span class="quote">> Test Regression is good, horray!
>
> Now let's look at the code :-)
>
> First the small easy stuff ;-)
>
> In the qt4 frotend there's this change
>
> - m_doc->doc->getDocInfo( &info );
> - if ( !info.isDict() )
> + XRef *xref = m_doc->doc->getXRef()->copy();
> + Object *infoObj = xref->getDocInfo(&info);
> + if ( !infoObj->isDict() ) {
> return QStringList();
> + }
>
> - Dict *infoDict = info.getDict();
> + Dict *infoDict = infoObj->getDict();
>
>
> Any reason we can not keep using info? i.e. something like
>
> - m_doc->doc->getDocInfo( &info );
> + XRef *xref = m_doc->doc->getXRef()->copy();
> + xref->getDocInfo(&info);
> if ( !info.isDict() )
> return QStringList();
>
> Dict *infoDict = info.getDict();
> </span >
No idea why I thought such complicate.Your code looks definitely smarter.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>