<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - make qt4 frontend thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=59927#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - make qt4 frontend thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=59927">bug 59927</a> from <a class="email" href="mailto:adamreichold@myopera.com" title="Adam Reichold <adamreichold@myopera.com>"> Adam Reichold</a> <pre>(In reply to <a href="show_bug.cgi?id=59927#c1">comment #1</a>) > Created <a href="attachment.cgi?id=73725" name="attach_73725" title="okular testcase">attachment 73725</a> <a href="attachment.cgi?id=73725&action=edit" title="okular testcase">[details]</a> <a href='page.cgi?id=splinter.html&bug=59927&attachment=73725'>[review]</a> [review] > okular testcase > > And here my okular testcase. > @Adam: I allow me to add You to the CC list. One of the reasons is that I > can't reconstruct the problems with Page::search, okular uses Page::textList > instead of it, and that was already thread-safe with commit of <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - library should be thread-safe" href="show_bug.cgi?id=50992">bug 50992</a>. If > You still get problems with Page::search, can You provide a testcase for it > or tell me, how I can reconstruct it? Thanks for keeping me in the loop! As you already pointed out on the mailing list, changing the call to displayPage using the TextOutputDev and hence this patch seems to have solved the search-while-render problem. Concerning the POPPLER_QT4_THREADSAFE definition, I could personally live without it since I build with defines for the Poppler version given by pkg-config. But I also do not see a problem with it and advertising this feature is probably nice as well. To round it up and get a definite statement: With this patch applied, I can consider the complete qt4 frontend thread-safe? Meaning that I can remove all locks that protect a document object and its children? (Including life cycle stuff like adding annotations?)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>