<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Some colors appear grey/black, whereas it works with Adobe Reader" href="https://bugs.freedesktop.org/show_bug.cgi?id=59179#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Some colors appear grey/black, whereas it works with Adobe Reader" href="https://bugs.freedesktop.org/show_bug.cgi?id=59179">bug 59179</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>(In reply to <a href="show_bug.cgi?id=59179#c6">comment #6</a>) > Created <a href="attachment.cgi?id=73644" name="attach_73644" title="support uncolored tiling patterns">attachment 73644</a> <a href="attachment.cgi?id=73644&action=edit" title="support uncolored tiling patterns">[details]</a> <a href='page.cgi?id=splinter.html&bug=59179&attachment=73644'>[review]</a> [review] > support uncolored tiling patterns > > It turns out that we can't use cairo_mask for uncolored patterns since > cairo_mask uses the alpha and not the luminosity to mask the source. > > This patch uses the same solution as uncolored patterns in PSOutputDev. It > adds a flag to indicate we are rendering an uncolored pattern and disables > setting the color when the flag is true. Great, no regressions this time. Thanks! Please, don't use braces for single statement ifs. Feel free to push.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>