<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:evan@coeus-group.com" title="Evan Nemerson <evan@coeus-group.com>"> <span class="fn">Evan Nemerson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Various minor introspection improvements"
href="https://bugs.freedesktop.org/show_bug.cgi?id=45384">bug 45384</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #56312 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Various minor introspection improvements"
href="https://bugs.freedesktop.org/show_bug.cgi?id=45384#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Various minor introspection improvements"
href="https://bugs.freedesktop.org/show_bug.cgi?id=45384">bug 45384</a>
from <span class="vcard"><a class="email" href="mailto:evan@coeus-group.com" title="Evan Nemerson <evan@coeus-group.com>"> <span class="fn">Evan Nemerson</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=74809" name="attach_74809" title="glib: add documentation for PopplerActions">attachment 74809</a> <a href="attachment.cgi?id=74809&action=edit" title="glib: add documentation for PopplerActions">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=45384&attachment=74809'>[review]</a>
glib: add documentation for PopplerActions
<span class="quote">> ::: glib/poppler-action.h
> @@ +261,5 @@
> > };
> >
> > +/**
> > + * PopplerActionOCGState:
> > + * @type: action type
>
> We know the action type, so add it in parentheses:
>
> @type: action type (%POPPLER_ACTION_OCG_STATE)</span >
Okay, done for all of them.
<span class="quote">> @@ +263,5 @@
> > +/**
> > + * PopplerActionOCGState:
> > + * @type: action type
> > + * @title: action title
> > + * @state_list: (element-type PopplerActionLayer): list of #PopplerActionLayer<-- -->s
>
> We should explain briefly what this action is for.</span >
I honestly have no idea what this action is for. Or any of them, really. I'm
not at all familiar with the Poppler API, just trying to get introspection up
to snuff.
I've copied what could be called, if you're feeling generous, brief
explanations from the PopplerActionType enum, but it would be nice if someone
who knows the API could improve it.
<span class="quote">> @@ +264,5 @@
> > + * PopplerActionOCGState:
> > + * @type: action type
> > + * @title: action title
> > + * @state_list: (element-type PopplerActionLayer): list of #PopplerActionLayer<-- -->s
> > + */
>
> All other action types are also undocumented, I guess it's a good time to
> document all of them :-P</span >
I've done what I can. To be honest I haven't really added any insight, but it
should look a little better than empty docs.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>