<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - make qt4 frontend thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=59927#c18">Comment # 18</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - make qt4 frontend thread-safe" href="https://bugs.freedesktop.org/show_bug.cgi?id=59927">bug 59927</a> from <a class="email" href="mailto:adamreichold@myopera.com" title="Adam Reichold <adamreichold@myopera.com>"> Adam Reichold</a> <pre>(In reply to <a href="show_bug.cgi?id=59927#c17">comment #17</a>) > (In reply to <a href="show_bug.cgi?id=59927#c16">comment #16</a>) > > Commited, are we done in this one? > > > > P.S: Just had a look at the construct of Page::getResourceDict and i think > > it's a bit unseasy to use, do you think that in the "cleanup" bug we could > > instead use two functions? One that always does the copy and one that not? > > Now you have to keep track if you passed down a non null XRef to know if you > > have to delete it or not, which i think may be a bit cumbersome and error > > prone, what do you think? > > I'LL have a look at it abd try to find a better solution in <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cleanup patch for bug 50992" href="show_bug.cgi?id=59933">bug 59933</a>. > > BTW, during my tests with Adam's program I got one or two times crashes. But > the reason for it was the test program itself: two threads fetched the page > annots (without any problems) and the deleted the same annotation, the first > one wins and the second could crash. I cannot solve that in the library, > this is the one case I know where the calling program is responsible to lock > two threads against each other. I agree, as is stated in the documentation, the caller is responsible that no more objects refer to a specific annotation before calling "Page::removeAnnotation", so this is invalid usage, even if it is done in a single thread. > @Adam: Any known open issues or can we close this bug now? Nothing comes to mind.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>