<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cleanup patch for bug 50992" href="https://bugs.freedesktop.org/show_bug.cgi?id=59933#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cleanup patch for bug 50992" href="https://bugs.freedesktop.org/show_bug.cgi?id=59933">bug 59933</a> from <a class="email" href="mailto:adamreichold@myopera.com" title="Adam Reichold <adamreichold@myopera.com>"> Adam Reichold</a> <pre>(In reply to <a href="show_bug.cgi?id=59933#c3">comment #3</a>) > Created <a href="attachment.cgi?id=75446" name="attach_75446" title="cleanup code">attachment 75446</a> <a href="attachment.cgi?id=75446&action=edit" title="cleanup code">[details]</a> <a href='page.cgi?id=splinter.html&bug=59933&attachment=75446'>[review]</a> [review] > cleanup code > > Here now the complete cleanup patch. Even if successfully regtested, please > have again a deeper look into the code. Just a short remark on the "Lock" class: I think you could merge the two constructors using a default argument, e.g. Lock(GooMutex *mutexA, LockMode modeA = DoLock) : mutex(mutexA) { mode = modeA; if (mode == DoLock) gLockMutex(mutex); } and comparing it with Qt's QMutexLocker, explicit "lock" and "unlock" methods might be useful if one wants to break RAII locally.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>