<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cleanup patch for bug 50992" href="https://bugs.freedesktop.org/show_bug.cgi?id=59933#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cleanup patch for bug 50992" href="https://bugs.freedesktop.org/show_bug.cgi?id=59933">bug 59933</a> from <a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> Thomas Freitag</a> <pre>(In reply to <a href="show_bug.cgi?id=59933#c4">comment #4</a>) > (In reply to <a href="show_bug.cgi?id=59933#c3">comment #3</a>) > > Created <a href="attachment.cgi?id=75446" name="attach_75446" title="cleanup code">attachment 75446</a> <a href="attachment.cgi?id=75446&action=edit" title="cleanup code">[details]</a> <a href='page.cgi?id=splinter.html&bug=59933&attachment=75446'>[review]</a> [review] [review] > > cleanup code > > > > Here now the complete cleanup patch. Even if successfully regtested, please > > have again a deeper look into the code. > > Just a short remark on the "Lock" class: I think you could merge the two > constructors using a default argument, e.g. > > Lock(GooMutex *mutexA, LockMode modeA = DoLock) : mutex(mutexA) { mode = > modeA; if (mode == DoLock) gLockMutex(mutex); } > > and comparing it with Qt's QMutexLocker, explicit "lock" and "unlock" > methods might be useful if one wants to break RAII locally. Can You take over and implement it based on my patch or do it in an additional step if Albert agrees? Reason for my question: I agree to Your comment, but I'm working such a long time and too much hours on this feature that I'm getting too tired to spend any unnecessary additional hour :-(</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>