<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Cleanup patch for bug 50992"
href="https://bugs.freedesktop.org/show_bug.cgi?id=59933#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Cleanup patch for bug 50992"
href="https://bugs.freedesktop.org/show_bug.cgi?id=59933">bug 59933</a>
from <span class="vcard"><a class="email" href="mailto:adamreichold@myopera.com" title="Adam Reichold <adamreichold@myopera.com>"> <span class="fn">Adam Reichold</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=59933#c5">comment #5</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=59933#c4">comment #4</a>)
> > (In reply to <a href="show_bug.cgi?id=59933#c3">comment #3</a>)
> > > Created <span class=""><a href="attachment.cgi?id=75446" name="attach_75446" title="cleanup code">attachment 75446</a> <a href="attachment.cgi?id=75446&action=edit" title="cleanup code">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=59933&attachment=75446'>[review]</a> [review] [review] [review]
> > > cleanup code
> > >
> > > Here now the complete cleanup patch. Even if successfully regtested, please
> > > have again a deeper look into the code.
> >
> > Just a short remark on the "Lock" class: I think you could merge the two
> > constructors using a default argument, e.g.
> >
> > Lock(GooMutex *mutexA, LockMode modeA = DoLock) : mutex(mutexA) { mode =
> > modeA; if (mode == DoLock) gLockMutex(mutex); }
> >
> > and comparing it with Qt's QMutexLocker, explicit "lock" and "unlock"
> > methods might be useful if one wants to break RAII locally.
>
> Can You take over and implement it based on my patch or do it in an
> additional step if Albert agrees? Reason for my question: I agree to Your
> comment, but I'm working such a long time and too much hours on this feature
> that I'm getting too tired to spend any unnecessary additional hour :-(</span >
Of course, I'll wait till this is merged and propose a small patch afterwards.
Thanks for all the hard work!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>