<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cleanup patch for bug 50992" href="https://bugs.freedesktop.org/show_bug.cgi?id=59933#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cleanup patch for bug 50992" href="https://bugs.freedesktop.org/show_bug.cgi?id=59933">bug 59933</a> from <a class="email" href="mailto:tsdgeos@terra.es" title="Albert Astals Cid <tsdgeos@terra.es>"> Albert Astals Cid</a> <pre>Created <a href="attachment.cgi?id=75854" name="attach_75854" title="Patch on top of Thomas'">attachment 75854</a> <a href="attachment.cgi?id=75854&action=edit" title="Patch on top of Thomas'">[details]</a> <a href='page.cgi?id=splinter.html&bug=59933&attachment=75854'>[review]</a> Patch on top of Thomas' I'm attaching a patch that i want to commit on top of Thomas' it has a few changes: * Remove the namespace (we don't use much/any namespaces in poppler core) * Rename the class and defines from lock to locker since lock and be either the action "to lock" or the "thing that locks", with locker it is more clear (i think) that is "the thing" than "the action" * Make Annot::decRefCnt use gLockMutex since we the object itself is being deleted in the if and not sure the locker would be happy with that * change the getNumPages() param to be DoNotLockMutex since previously it was a gFalse (i guess Thomas made a c&p typo here) * Have only one constructor like Adam suggested. Comments?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>