<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Cleanup patch for bug 50992"
href="https://bugs.freedesktop.org/show_bug.cgi?id=59933#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Cleanup patch for bug 50992"
href="https://bugs.freedesktop.org/show_bug.cgi?id=59933">bug 59933</a>
from <span class="vcard"><a class="email" href="mailto:adamreichold@myopera.com" title="Adam Reichold <adamreichold@myopera.com>"> <span class="fn">Adam Reichold</span></a>
</span></b>
<pre>Hello Albert,
(In reply to <a href="show_bug.cgi?id=59933#c7">comment #7</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=75854" name="attach_75854" title="Patch on top of Thomas'">attachment 75854</a> <a href="attachment.cgi?id=75854&action=edit" title="Patch on top of Thomas'">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=59933&attachment=75854'>[review]</a> [review]
> Patch on top of Thomas'
>
> I'm attaching a patch that i want to commit on top of Thomas' it has a few
> changes:
> * Remove the namespace (we don't use much/any namespaces in poppler core)</span >
Actually, I had a few stray crashes in qpdfview because of pure virtual methods
being called through naming collisions with Poppler internal (e.g. defining an
::Outline class), but of course, namespacing the Locker won't help that. :-)
<span class="quote">> * Rename the class and defines from lock to locker since lock and be either
> the action "to lock" or the "thing that locks", with locker it is more clear
> (i think) that is "the thing" than "the action"</span >
I agree, it is clearer.
<span class="quote">> * Make Annot::decRefCnt use gLockMutex since we the object itself is being
> deleted in the if and not sure the locker would be happy with that</span >
Makes sense.
<span class="quote">> * change the getNumPages() param to be DoNotLockMutex since previously it
> was a gFalse (i guess Thomas made a c&p typo here)
> * Have only one constructor like Adam suggested.
>
> Comments?</span >
Best regards, Adam.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>