<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Should not try to fopen a file we already have open" href="https://bugs.freedesktop.org/show_bug.cgi?id=62735#c9">Comment # 9</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Should not try to fopen a file we already have open" href="https://bugs.freedesktop.org/show_bug.cgi?id=62735">bug 62735</a> from <a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> Adrian Johnson</a> <pre>(In reply to <a href="show_bug.cgi?id=62735#c5">comment #5</a>) > Created <a href="attachment.cgi?id=77021" name="attach_77021" title="patch to keep using old-style I/O on Win32">attachment 77021</a> <a href="attachment.cgi?id=77021&action=edit" title="patch to keep using old-style I/O on Win32">[details]</a> <a href='page.cgi?id=splinter.html&bug=62735&attachment=77021'>[review]</a> [review] > patch to keep using old-style I/O on Win32 > > This slightly convoluted patch uses #ifdefs to keep the old-style I/O, and > UniqueFileStream as an implementation detail, around for Win32. *Not tested > on an actual Win32 host.* > > (This is so ugly... Couldn't Poppler depend on Cygwin or some other form of > POSIX layer... :-() It would be nice to have a solution that didn't require all the #ifdefs. I know this is what we have done in the past but it would be better if the #ifdefs were confined to the header files and win32 specific code is put in a separate file. This also avoids polluting the namespace with all the junk in windows.h.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>