<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Should not try to fopen a file we already have open"
href="https://bugs.freedesktop.org/show_bug.cgi?id=62735#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Should not try to fopen a file we already have open"
href="https://bugs.freedesktop.org/show_bug.cgi?id=62735">bug 62735</a>
from <span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=62735#c13">comment #13</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=77289" name="attach_77289" title="add a GooFile class to encapsulate file read access using offsets">attachment 77289</a> <a href="attachment.cgi?id=77289&action=edit" title="add a GooFile class to encapsulate file read access using offsets">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=62735&attachment=77289'>[review]</a> [review]
> add a GooFile class to encapsulate file read access using offsets
>
> Hopefully, I have made the necessary additions for autotools and CMake to
> generate the 'pread64' and 'lseek64' definitions. I also removed the - as
> far as I can see - by now superfluous calls to 'stat' where file streams are
> constructed since we can just use 'GooFile::size'.
>
> @Albert: I will run regtest on this version overnight (looking good so far),
> but I think this is basically ready for review.
>
> @Thomas: I used Poppler's default regtest which AFAIK is non-threaded since
> the default pdftoppm is. I did do a bit of smoke testing using qpdfview and
> multi-threading.</span >
I just ran Your patch through my regression test with the multi-threaded
version of pdftoppm, and I just got the same failed tests than in
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - library should be thread-safe"
href="show_bug.cgi?id=50992#c124">https://bugs.freedesktop.org/show_bug.cgi?id=50992#c124</a> (beside the failed test
caused by tiling patterns, because we solved that in the meantime).
This also helps on systems where a virus scanner is installed: because we open
the PDF now only once, the virus scanner scans it only one time.
Also it seems to be a little bit faster, but this could just be a subjective
feeling.
I also compiled it under Windows and made a few tests without any problems.
Congratulation!!!!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>