<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Misuse of setjmp in DCTStream"
href="https://bugs.freedesktop.org/show_bug.cgi?id=63067">63067</a>
</td>
</tr>
<tr>
<th>Assignee</th>
<td>poppler-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Summary</th>
<td>Misuse of setjmp in DCTStream
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Reporter</th>
<td>rodrigorivascosta@gmail.com
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Component</th>
<td>general
</td>
</tr>
<tr>
<th>Product</th>
<td>poppler
</td>
</tr></table>
<p>
<div>
<pre>According to POSIX and the C spec, `setjmp` should only be used as the "entire
controlling expression" of a selection of iteration statement, possibly with
`!` or `== 0` or similar.
But in DCTStream.cc is the line:
if (!setjmp(err.setjmp_buffer) && jpeg_read_header(&cinfo, TRUE) !=
JPEG_SUSPENDED)
If I'm not mistaken, that is undefined behavior. Not that it broke anything
yet...
Instead it should be:
if (!setjmp(err.setjmp_buffer))
{
if (jpeg_read_header(&cinfo, TRUE) != JPEG_SUSPENDED)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>