<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - cppcheck report" href="https://bugs.freedesktop.org/show_bug.cgi?id=65551#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - cppcheck report" href="https://bugs.freedesktop.org/show_bug.cgi?id=65551">bug 65551</a> from <a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> Julien Nabet</a> <pre>Thank you Albert for your quick feedback. However, there are still some like these: [splash/Splash.cc:3802] -> [splash/Splash.cc:3802]: (style) Same expression on both sides of '||' [utils/HtmlOutputDev.cc:1704]: (error) Memory leak: str [poppler/Annot.cc:3161] -> [poppler/Annot.cc:3159]: (style) Found duplicate branches for 'if' and 'else'. [poppler/Annot.cc:3859] -> [poppler/Annot.cc:3857]: (style) Found duplicate branches for 'if' and 'else'. which may not only style problem. (on the contrary of Reduce scope, casting, etc). I'll try to send other patches in the next days for style. (except casts because I never know when to use dynamic cast vs static cast for eg)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>