<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [TAGGEDPDF] Parse the Tagged-PDF document structure tree when present" href="https://bugs.freedesktop.org/show_bug.cgi?id=64815#c10">Comment # 10</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [TAGGEDPDF] Parse the Tagged-PDF document structure tree when present" href="https://bugs.freedesktop.org/show_bug.cgi?id=64815">bug 64815</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>(In reply to <a href="show_bug.cgi?id=64815#c9">comment #9</a>) > > Maybe you can split the patch in those 3 things? to make it a bit easier to > > review? > > Ouch, the commit message does not really describe well the patch after > the rebasing/squashing done prior to uploading. But I can split it up > in three logical parts: > > - Defining the StructElement class and parsing of the corresponding > objects from the PDF. > - Defining the Attribute class and parsing the corresponding objects > from the PDF. > - Text content extraction, a.k.a. the machinery needed for > StructElement::getText() and StructElement::getMCOps() > > If there's no objections, I would upload an updated version with the > patch split in three mentioned above soon. Sounds good to me, I think I would split it even more, since the patch is mixing 2 things, document logical structure and tagged PDFs. The first patch could define the StructTreeRoot and StructTreeElement without any tagged PDF info. And an top of logical structure support, add tagged PDF implementation. I'll do a first review of the current patch anyway, but upload a new version split.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>