<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Parse the Tagged-PDF document structure tree when present"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64815#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Parse the Tagged-PDF document structure tree when present"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64815">bug 64815</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=81008" name="attach_81008" title="[PATCH v5 01/10] Tagged-PDF: Accessors in Catalog for the MarkInfo dictionary">attachment 81008</a> <a href="attachment.cgi?id=81008&action=edit" title="[PATCH v5 01/10] Tagged-PDF: Accessors in Catalog for the MarkInfo dictionary">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64815&attachment=81008'>[review]</a>
[PATCH v5 01/10] Tagged-PDF: Accessors in Catalog for the MarkInfo dictionary
Review of <span class=""><a href="attachment.cgi?id=81008" name="attach_81008" title="[PATCH v5 01/10] Tagged-PDF: Accessors in Catalog for the MarkInfo dictionary">attachment 81008</a> <a href="attachment.cgi?id=81008&action=edit" title="[PATCH v5 01/10] Tagged-PDF: Accessors in Catalog for the MarkInfo dictionary">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64815&attachment=81008'>[review]</a>:
-----------------------------------------------------------------
This looks good to me.
::: poppler/Catalog.h
@@ +129,5 @@
<span class="quote">> + enum MarkInfoFlags {
> + markInfoNull = (1 << 0),
> + markInfoMarked = (1 << 1),
> + markInfoUserProperties = (1 << 2),
> + markInfoSuspects = (1 << 3),</span >
I think you don't need parentheses for the enum values.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>