<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Poppler ignores rendering intents and always uses INTENT_RELATIVE_COLORIMETRIC"
href="https://bugs.freedesktop.org/show_bug.cgi?id=34053">bug 34053</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #43180 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Poppler ignores rendering intents and always uses INTENT_RELATIVE_COLORIMETRIC"
href="https://bugs.freedesktop.org/show_bug.cgi?id=34053#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Poppler ignores rendering intents and always uses INTENT_RELATIVE_COLORIMETRIC"
href="https://bugs.freedesktop.org/show_bug.cgi?id=34053">bug 34053</a>
from <span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=83659" name="attach_83659" title="use icc profile in OutputIntents if possible">attachment 83659</a> <a href="attachment.cgi?id=83659&action=edit" title="use icc profile in OutputIntents if possible">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=34053&attachment=83659'>[review]</a>
use icc profile in OutputIntents if possible
You were already quite close to a solution, Albert. There is just one main
difference in my patch: it tries to use the icc profile in OutputIntents, if
possible, and that solves it.
If You look at the patch and compare it with Yours, You'll see that the most
other changes come due to the fact that You change the colorspace caching from
gfx to outputdevice in the meantime, but to keep Your patch running we at least
need the state to get the current rendering intent.
Another small change is in caching: because the transformation depends now on
the current rendering intent, a cached icc based colorspace can not be used if
the rendering intent changed in the meantime. But that was just missing in Your
patch.
And as I already told on the mailing list: to see differences in the altona pdf
(and much easier to see in the GWG 7er series), You have to render in CMYK
(because the profile in OutputIntents is a CMYK profile). Therefore You need to
compile with the SPLASH_CMYK directive and can't use the -png-format parameter,
use -jpegcmyk instead as pdftoppm parameter.
Two open points in my opinion:
1. Because the display profile now depends on the PDF, we can't use a static
variable for it anymore. It will not make any difference if just one
apllication uses the poppler library at the same time, and so I would prefer to
solve that in a second step (store the display profile in the doc instance and
use the static as default).
2. We have now the second case where we definitely need the library compiled
with SPLASH_CMYK (the other is the overprint usage). Shouldn't we make
SPLASH_CMYK defined by default, and perhaps remove it completely in an
additional step? I know that the library become bigger in size, but is this
really such important?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>