<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Does not build with gtk+ master (3.10) when deprecated symbols are disabled" href="https://bugs.freedesktop.org/show_bug.cgi?id=67278#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Does not build with gtk+ master (3.10) when deprecated symbols are disabled" href="https://bugs.freedesktop.org/show_bug.cgi?id=67278">bug 67278</a> from <a class="email" href="mailto:apinheiro@igalia.com" title="Alejandro Piñeiro <apinheiro@igalia.com>"> Alejandro Piñeiro</a> <pre>(In reply to <a href="show_bug.cgi?id=67278#c2">comment #2</a>) > (In reply to <a href="show_bug.cgi?id=67278#c1">comment #1</a>) > > why does it fail to build? it should give just compile warnings, that we > > should silence, but I don't think we need to change the code for symbols > > deprecated in a gtk+ version higher than the required one > > At least in GNOME, jhbuild disables deprecated symbols by default. Sorry, but that is not accurate. jhbuild doesn't do that by default. FWIW, just in case, I made a sanity check: <API> fredp, ping <API> although probably jjardon also knows that <fredp> pong <API> fredp, here: <API> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Does not build with gtk+ master (3.10) when deprecated symbols are disabled" href="show_bug.cgi?id=67278#c2">https://bugs.freedesktop.org/show_bug.cgi?id=67278#c2</a> <API> it says that "jhbuild disables deprecated symbols by default" <API> that sounds really wrong to me <fredp> well, we don't <fredp> I thought maybe the jhbuildrc we publish along tarballs does, but not even. > I saw 2 options: > 1. Add an option in jhbuild to not check deprecated symbols. Well, as I said, the problem is not at jhbuild. After doing some searching I found that poppler is hardcoding GTK_DISABLE_DEPRECATED at glib/demo/Makefile.am. More about the previous chat, that include some suggestions: <API> fredp, ok, thanks, just wanted a sanity check <fredp> so perhaps there is a wiki page that hints at --disable-deprecated <fredp> I'll check <API> fredp, well, I think that this poppler fault <API> from his Makefile.am, have just found this: <API> INCLUDES = \ <API> -I$(top_srcdir)/glib \ <API> -I$(top_builddir)/glib \ <API> $(GTK_TEST_CFLAGS) \ <API> $(POPPLER_GLIB_DISABLE_DEPRECATED) \ <API> -DGTK_DISABLE_DEPRECATED \ <API> $(POPPLER_GLIB_DISABLE_SINGLE_INCLUDES) <API> they are hardcoding -DGTK_DISABLE_DEPRECATED <API> imho, that should be added(or not) at POPPLER_GLIB_DISABLE_DEPRECATED, that is the one that is filled on the configure.ac <walters> IMO all of those things should just be deleted <walters> the new way of handing deprecations is just better in every way <API> walters, perhaps a new gnome goal? * API checking, just in case that goal already exists <walters> sure, though there's not that many projects using them still i don't think <API> walters, well, at least poppler is ;) <API> and they blame jhbuild <API> in any case, thanks for the feedback, I will comment on the bug * walters did <a href="https://git.gnome.org/browse/libbonobo/commit/?id=fef13a371fc91f6d9b42518126c2a8b459fdf0e8">https://git.gnome.org/browse/libbonobo/commit/?id=fef13a371fc91f6d9b42518126c2a8b459fdf0e8</a> a while ago for example</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>