<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - 100% CPU usage" href="https://bugs.freedesktop.org/show_bug.cgi?id=66928#c20">Comment # 20</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - 100% CPU usage" href="https://bugs.freedesktop.org/show_bug.cgi?id=66928">bug 66928</a> from <a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> Thomas Freitag</a> <pre>(In reply to <a href="show_bug.cgi?id=66928#c19">comment #19</a>) > Thomas, the patch looks good, but before regtesting+committing I went ahead > and tried the Cairo backend and it's relly fast without this patch. > > I see that the difference is that they call getRGBLine instead of getRBG, > and that seems to make lcms much happier. > > Before introducing this cache (that can increase the memory usage quite a > bit), do you think it makes sense to explore the use of getRBGLine instead > of gerRBG? Do you have time to look at that or want me to try to find some > time? I'll have a look at it, Albert (unfotunately I have to work this weekend, but perhaps I'll find some time during next week). On the other hand: with the patch I don't cache the return values of getRGBLine(), so the usage of it will not increase memory usage dramatically even with my patch. So wouldn't it be a good idea to have it both: have a fast usage of getRGB() but use getRGBLine() where ever it is possible?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>