<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Greek support package - some characters output as symbols not letters"
href="https://bugs.freedesktop.org/show_bug.cgi?id=66693#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Greek support package - some characters output as symbols not letters"
href="https://bugs.freedesktop.org/show_bug.cgi?id=66693">bug 66693</a>
from <span class="vcard"><a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> <span class="fn">Adrian Johnson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=84138" name="attach_84138" title="Normalize more characters in font Unicode map">attachment 84138</a> <a href="attachment.cgi?id=84138&action=edit" title="Normalize more characters in font Unicode map">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=66693&attachment=84138'>[review]</a>
Normalize more characters in font Unicode map
Review of <span class=""><a href="attachment.cgi?id=84138" name="attach_84138" title="Normalize more characters in font Unicode map">attachment 84138</a> <a href="attachment.cgi?id=84138&action=edit" title="Normalize more characters in font Unicode map">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=66693&attachment=84138'>[review]</a>:
-----------------------------------------------------------------
::: poppler/GfxFont.cc
@@ +1438,5 @@
<span class="quote">> + || u[i] == 0x220F // â
> + || u[i] == 0x2211 // â
> + || (u[i] >= 0xFB00 && u[i] <= 0xFB4F) // Alphabetic Presentation Forms
> + || (u[i] >= 0xFB50 && u[i] <= 0xFDFF) // Arabic Presentation Forms-A
> + || (u[i] >= 0xFE70 && u[i] <= 0xFEFF) // Arabic Presentation Forms-B</span >
I don't like the way all the characters to normalize have been shoved into an
if statement like this. Could they be put in a table or something where there
is a separation between the list of characters and the code to perform the
normalization?
It would also be good if you could include the removed comment that provided
examples of the alphabetic presentation forms 'eg "fi", "ffi"' as not everyone
who will read this code is familiar with the various unicode ranges.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>