<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - handling of rtl text inversion is too naive" href="https://bugs.freedesktop.org/show_bug.cgi?id=55977#c40">Comment # 40</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - handling of rtl text inversion is too naive" href="https://bugs.freedesktop.org/show_bug.cgi?id=55977">bug 55977</a> from <a class="email" href="mailto:alexbodn.groups@gmail.com" title="alex <alexbodn.groups@gmail.com>"> alex</a> <pre>(In reply to <a href="show_bug.cgi?id=55977#c39">comment #39</a>) hello albert, > Alex please accept my apologies for taking again so long into looking at > this patch (note this may happen again since i'll be on holiday for the most > of september). no problem. enjoy your hollyday. you're already doing much for this project, while my contribution is quite a niche one. > > Two things: > * Your patch is patching stuff like Makefile.in which tells me you're not > using git diff but developing about a packaged version. That makes no sense > for a new feature like this you should develop against git master indeed i'm developing against old poppler 0.20.5, as it's installed on my debian system. that's because my fear the compiled libraries will not be integrated in my running system otherwise. makefile.in files are indeed in the patch, as generated by the debian package building utility. but i have naturally done no change to these files, and they may be safely removed from the patch. i'll do it if you wish. > * As said, new features like this can only enter git master for the next > version. If i try to apply this patch to current git master, the patch fails > to apply. Can you please update the patch so that it does apply against git > master? as said. thanks and enjoy your hollyday, alex</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>