<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cache lcms transformed values for ICC colorspaces in getRGB(), getCMYK() and getGray()" href="https://bugs.freedesktop.org/show_bug.cgi?id=68420#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cache lcms transformed values for ICC colorspaces in getRGB(), getCMYK() and getGray()" href="https://bugs.freedesktop.org/show_bug.cgi?id=68420">bug 68420</a> from <a class="email" href="mailto:aacid@kde.org" title="Albert Astals Cid <aacid@kde.org>"> Albert Astals Cid</a> <pre>I do get a reasonable increase too, from 2400ms to 1800ms Two things: * It'd be cool if we could reuse the key and not calculate it twice, but then it'll probably make the code harder to read, so ignore * It'd be cool if we had "a proper cache" and not just cache the first 2048 items, so probably ignore too :D Only thing, is i think i prefer #define CMSCACHE_LIMIT 2048 in the .cc and not in the header, but that's just me nitpicking. So should i start the regtest just in case something bad went wrong or you prefer to get <a class="bz_bug_link bz_status_NEW " title="NEW --- - Poppler ignores rendering intents and always uses INTENT_RELATIVE_COLORIMETRIC" href="show_bug.cgi?id=34053">bug 34053</a> commited first as you say in the bug description?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>