<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Tagged-PDF: LBody tag is not supported" href="https://bugs.freedesktop.org/show_bug.cgi?id=67710#c9">Comment # 9</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Tagged-PDF: LBody tag is not supported" href="https://bugs.freedesktop.org/show_bug.cgi?id=67710">bug 67710</a> from <a class="email" href="mailto:aperez@igalia.com" title="Adrian Perez de Castro <aperez@igalia.com>"> Adrian Perez de Castro</a> <pre>Comment on <a href="attachment.cgi?id=83604" name="attach_83604" title="Add support to LBody tag at poppler-glib">attachment 83604</a> <a href="attachment.cgi?id=83604&action=edit" title="Add support to LBody tag at poppler-glib">[details]</a> <a href='page.cgi?id=splinter.html&bug=67710&attachment=83604'>[review]</a> Add support to LBody tag at poppler-glib Review of <a href="attachment.cgi?id=83604" name="attach_83604" title="Add support to LBody tag at poppler-glib">attachment 83604</a> <a href="attachment.cgi?id=83604&action=edit" title="Add support to LBody tag at poppler-glib">[details]</a> <a href='page.cgi?id=splinter.html&bug=67710&attachment=83604'>[review]</a>: ----------------------------------------------------------------- Apart from a part of the patch being unneded, the rest looks good to me. ::: glib/poppler-structure.cc @@ +104,5 @@ > return StructElement::LI; > case POPPLER_STRUCTURE_ELEMENT_LIST_LABEL: > return StructElement::Lbl; > + case POPPLER_STRUCTURE_ELEMENT_LIST_BODY: > + return StructElement::LBody; This hunk from the patch won't be needed in the end. After discussing the Poppler-GLib API with Carlos García, there will not be a PopplerStructure object any more — traversing the structure will be done by obtaining a PopplerStructureElementIter directly from the PopplerDocument.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>