<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Parse the Tagged-PDF document structure tree when present"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64815#c47">Comment # 47</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Parse the Tagged-PDF document structure tree when present"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64815">bug 64815</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=86675" name="attach_86675" title="[PATCH v8 02/15] Implement Object::takeString() method">attachment 86675</a> <a href="attachment.cgi?id=86675&action=edit" title="[PATCH v8 02/15] Implement Object::takeString() method">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64815&attachment=86675'>[review]</a>
[PATCH v8 02/15] Implement Object::takeString() method
Review of <span class=""><a href="attachment.cgi?id=86675" name="attach_86675" title="[PATCH v8 02/15] Implement Object::takeString() method">attachment 86675</a> <a href="attachment.cgi?id=86675&action=edit" title="[PATCH v8 02/15] Implement Object::takeString() method">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64815&attachment=86675'>[review]</a>:
-----------------------------------------------------------------
::: poppler/Object.h
@@ +199,5 @@
<span class="quote">> double getNum() { OBJECT_3TYPES_CHECK(objInt, objInt64, objReal);
> return type == objInt ? (double)intg : type == objInt64 ? (double)int64g : real; }
> GooString *getString() { OBJECT_TYPE_CHECK(objString); return string; }
> + GooString *takeString() {
> + OBJECT_TYPE_CHECK(objString); GooString *s = string; initNull(); return s; }</span >
I don't think we should call initNull. We are just stealing the object
contents, but the object type should not change. Also calling initNull here
would unbalance the numAllocs array increments/decrements when memory debug is
enabled. I think we should just set string to NULL, so that when free() is
called it will do nothing.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>